Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fine_tuning] Work on Ray testing and visualization #584

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[fine_tuning] Work on Ray testing and visualization #584

wants to merge 9 commits into from
+445 −42

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Nov 7, 2024

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kpouget. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@topsail-bot TOPSAIL Bot
Copy link

topsail-bot bot commented Nov 7, 2024

Jenkins Job #1622

🔴 Test of 'rhoai test test_ci' failed after 00 hours 00 minutes 24 seconds. 🔴

• Link to the test results.

• Link to the reports index.

Test configuration:

# RHOAI: run fine_tuning test test_ci
PR_POSITIONAL_ARGS: ray_bench_scale
PR_POSITIONAL_ARG_0: fine_tuning-perf-ci
PR_POSITIONAL_ARG_1: ray_bench_scale

• Link to the Rebuild page.

Failure indicator: Empty. (See run.log)

[Test ran on the internal Perflab CI]

@topsail-bot TOPSAIL Bot
Copy link

topsail-bot bot commented Nov 7, 2024

Jenkins Job #1623

🔴 Test of 'rhoai test test_ci' failed after 00 hours 00 minutes 04 seconds. 🔴

• Link to the test results.

• Link to the reports index.

Test configuration:

# RHOAI: run fine_tuning test test_ci
PR_POSITIONAL_ARGS: ray_bench_scale
PR_POSITIONAL_ARG_0: fine_tuning-perf-ci
PR_POSITIONAL_ARG_1: ray_bench_scale

• Link to the Rebuild page.

Failure indicator: Empty. (See run.log)

[Test ran on the internal Perflab CI]

@topsail-bot TOPSAIL Bot
Copy link

topsail-bot bot commented Nov 7, 2024

Jenkins Job #1624

🔴 Test of 'rhoai test test_ci' failed after 01 hours 46 minutes 18 seconds. 🔴

• Link to the test results.

• Link to the reports index.

Test configuration:

# RHOAI: run fine_tuning test test_ci
PR_POSITIONAL_ARGS: ray_bench_scale
PR_POSITIONAL_ARG_0: fine_tuning-perf-ci
PR_POSITIONAL_ARG_1: ray_bench_scale

• Link to the Rebuild page.

Failure indicator:

/logs/artifacts/000_test_ci/000__matbenchmarking/FAILURE | MatrixBenchmark benchmark failed.
/logs/artifacts/000_test_ci/000__matbenchmarking/fine-tuning/001__fine-tuning/001__ray__ray-benchmark/000__fine_tuning__ray_fine_tuning_job/FAILURE | [000__fine_tuning__ray_fine_tuning_job] ./run_toolbox.py from_config fine_tuning ray_fine_tuning_job --extra={'name': 'fine-tuning', 'gpu': 1, 'worker_replicas': 2, 'hyper_parameters': {'num_samples': 50}} --> 2
/logs/artifacts/000_test_ci/000__matbenchmarking/fine-tuning/001__fine-tuning/001__ray__ray-benchmark/FAILURE | CalledProcessError: Command 'set -o errexit;set -o pipefail;set -o nounset;set -o errtrace;ARTIFACT_DIR="/logs/artifacts/000_test_ci/000__matbenchmarking/fine-tuning/001__fine-tuning/001__ray__ray-benchmark" ./run_toolbox.py from_config fine_tuning ray_fine_tuning_job --extra="{'name': 'fine-tuning', 'gpu': 1, 'worker_replicas': 2, 'hyper_parameters': {'num_samples': 50}}"' returned non-zero exit status 2.
Traceback (most recent call last):
  File "/opt/topsail/src/projects/fine_tuning/testing/test_finetuning.py", line 139, in _run_test
    run.run_toolbox_from_config(
  File "/opt/topsail/src/projects/core/library/run.py", line 49, in run_toolbox_from_config
    return run(f'{cmd_env} ./run_toolbox.py from_config {group} {command} {_dict_to_run_toolbox_args(kwargs)}', **run_kwargs)
  File "/opt/topsail/src/projects/core/library/run.py", line 105, in run
    proc = subprocess.run(command, **args)

[...]

[Test ran on the internal Perflab CI]

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@topsail-bot TOPSAIL Bot
Copy link

topsail-bot bot commented Nov 8, 2024

Jenkins Job #1626

🔴 Test of 'rhoai test test_ci' failed after 01 hours 48 minutes 04 seconds. 🔴

• Link to the test results.

• Link to the reports index.

Test configuration:

# RHOAI: run fine_tuning test test_ci
PR_POSITIONAL_ARGS: ray_bench_scale
PR_POSITIONAL_ARG_0: fine_tuning-perf-ci
PR_POSITIONAL_ARG_1: ray_bench_scale

• Link to the Rebuild page.

Failure indicator:

/logs/artifacts/000_test_ci/000__matbenchmarking/FAILURE | MatrixBenchmark benchmark failed.
/logs/artifacts/000_test_ci/000__matbenchmarking/ray/001__ray/001__ray__ray-benchmark/000__fine_tuning__ray_fine_tuning_job/FAILURE | [000__fine_tuning__ray_fine_tuning_job] ./run_toolbox.py from_config fine_tuning ray_fine_tuning_job --extra={'name': 'ray', 'worker_replicas': 2, 'hyper_parameters': {'num_samples': 50}} --> 2
/logs/artifacts/000_test_ci/000__matbenchmarking/ray/001__ray/001__ray__ray-benchmark/FAILURE | CalledProcessError: Command 'set -o errexit;set -o pipefail;set -o nounset;set -o errtrace;ARTIFACT_DIR="/logs/artifacts/000_test_ci/000__matbenchmarking/ray/001__ray/001__ray__ray-benchmark" ./run_toolbox.py from_config fine_tuning ray_fine_tuning_job --extra="{'name': 'ray', 'worker_replicas': 2, 'hyper_parameters': {'num_samples': 50}}"' returned non-zero exit status 2.
Traceback (most recent call last):
  File "/opt/topsail/src/projects/fine_tuning/testing/test_finetuning.py", line 139, in _run_test
    run.run_toolbox_from_config(
  File "/opt/topsail/src/projects/core/library/run.py", line 49, in run_toolbox_from_config
    return run(f'{cmd_env} ./run_toolbox.py from_config {group} {command} {_dict_to_run_toolbox_args(kwargs)}', **run_kwargs)
  File "/opt/topsail/src/projects/core/library/run.py", line 105, in run
    proc = subprocess.run(command, **args)

[...]

[Test ran on the internal Perflab CI]

@kpouget
[fine_tuning] toolbox: fine_tuning_ray_fine_tuning_job: refactor to u…
f2a300f 
…se a workload (entrypoint+app) directory
@kpouget
[fine_tuning] testing: config: re-enable visualization for Ray
63f95e8
@kpouget
[fine_tuning] visualizations: fine_tuning: plotting/error_report: mak…
b3609f4 
…e compatible with Ray
@kpouget
[fine_tuning] visualizations: fine_tuning: store: extend the parsers …
a78e415 
…to work with Ray
@kpouget
[matrix_benchmarking] visualizations: helpers: store/parsers: log an …
e6484e5 
…error message if RHOAI version cannot be parsed

but don't crash
@kpouget
WIP: [fine_tuning] visualizations: fine_tuning: data/ray_benchmark: a…
696fbfe 
…dd a Ray Benchmark visualization
@kpouget
[fine_tuning] testing: config: add a 'ray_bench_scale' preset
87674aa
@kpouget
WIP: [fine_tuning] visualizations: fine_tuning: plotting/ray_benchmar…
8d75195 
…k: add a plotting file for Ray
@kpouget
[fine_tuning] visualizations: fine_tuning: plotting/__init__: enable …
7c7bd55 
…Ray plots
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpouget @openshift-merge-robot